feat: support Consul as ServiceRegistry #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/L
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 88.45% 88.16% -0.29%
==========================================
Files 117 119 +2
Lines 5682 5763 +81
==========================================
+ Hits 5026 5081 +55
- Misses 472 492 +20
- Partials 184 190 +6 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
size/XL
|
Could you investigate why the license check reports error? |
spacewander
reviewed
Jul 26, 2024
|
|
||
| const ( | ||
| //defaultConsulAddress = "127.0.0.1:8500" | ||
| defaultDatacenter = "dc1" |
There was a problem hiding this comment.
Unlike the defaultToken, defaultDatacenter is unused in the prod code?
spacewander
approved these changes
Jul 27, 2024
.licenserc.yaml
Outdated
| @@ -51,3 +51,5 @@ dependency: | |||
| excludes: | |||
| - name: github.com/dgryski/trifles # the author adds MIT License later | |||
| - name: github.com/rcrowley/go-metrics # this repo uses BSD-2-Clause-Views, which is not recognized in skywalking-eye 0.6 | |||
| - name: github.com/kr/logfmt #use MIT License | |||
There was a problem hiding this comment.
Suggested change
| - name: github.com/kr/logfmt #use MIT License | |
| - name: github.com/kr/logfmt # the author adds MIT License later |
|
👋 Hi, I detected conflicts against the base branch 🙊 |
spacewander
approved these changes
Jul 28, 2024
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #259
It's the part of run and stop the Consul