Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a new enum value in runtime.proto and compiled pb files #360

Closed
seeflood opened this issue Dec 13, 2021 · 2 comments
Closed

add a new enum value in runtime.proto and compiled pb files #360

seeflood opened this issue Dec 13, 2021 · 2 comments
Assignees
@stulzq
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@seeflood
Copy link
Member

seeflood commented Dec 13, 2021 •
edited
Loading

What would you like to be added:

Currently the HTTPExtension in our runtime.proto has the following enum values:
image
However dapr already has a new value PATCH, see
https://github.com/dapr/dapr/blob/42a901540f0f5a28a618721471ad208dfbf04a19/dapr/proto/common/v1/common.proto#L46
We should add this value in our proto and pb

Why is this needed:
@seeflood seeflood changed the title invokeService API add a new enum value in runtime.proto and compiled pb files Dec 13, 2021
@seeflood seeflood added kind/enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 13, 2021
stulzq added a commit to stulzq/layotto that referenced this issue Feb 21, 2022
@stulzq
add http verb PATCH mosn#360
6a15ec6
@stulzq
Copy link
Member

stulzq commented Feb 21, 2022

please assign to me

@stulzq stulzq mentioned this issue Feb 21, 2022
Merged
@stulzq
Copy link
Member

stulzq commented Feb 22, 2022

This issue can be closed

This was referenced Feb 23, 2022
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stulzq stulzq

Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stulzq @seeflood