feat: don't compile the actuator module if users don't need it #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c5d29d8
* dapr/state:add get/save state dapr api Signed-off-by: zach <zachchou016@gmail.com> * dapr/state:add query/delete state Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:replace cel-go with v0.5.1 Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:fix state api ut Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:init slice with cap Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api: remove encrypt dependency Signed-off-by: zach <zachchou016@gmail.com> * remove unused code * add comments Co-authored-by: seeflood <349895584@qq.com> # Conflicts: # pkg/grpc/dapr/dapr_api_state.go # pkg/grpc/dapr/dapr_api_unimplement.go # pkg/grpc/default_api/api.go # pkg/grpc/default_api/api_state.go
* dapr/state:add get/save state dapr api Signed-off-by: zach <zachchou016@gmail.com> * dapr/state:add query/delete state Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:replace cel-go with v0.5.1 Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:fix state api ut Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:init slice with cap Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api: remove encrypt dependency Signed-off-by: zach <zachchou016@gmail.com> * remove unused code * add comments Co-authored-by: seeflood <349895584@qq.com>
seeflood
requested review from
MoonShining,
zhenjunMa and
ZLBer
and removed request for
wenxuwan
seeflood
changed the title
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 56.87% 56.75% -0.13%
==========================================
Files 114 115 +1
Lines 6085 6093 +8
==========================================
- Hits 3461 3458 -3
- Misses 2270 2283 +13
+ Partials 354 352 -2
Continue to review full report at Codecov.
|
wenxuwan
reviewed
Feb 17, 2022
wenxuwan
approved these changes
Feb 17, 2022
zhenjunMa
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
main.goand delete actuator code so that the actuator module won't be compiledWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: