Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dead-link-checker can't find out dead links (#596) #609

Merged
merged 5 commits into from
May 30, 2022
Merged

fix: dead-link-checker can't find out dead links (#596) #609

merged 5 commits into from
May 30, 2022

Conversation

xujiajiadexiaokeai
Copy link
Contributor

What this PR does:

  1. update markdown-link-check version v3.8.7 -> v3

  2. optimize check-dead-link result display

  3. ignore internal anchor

Which issue(s) this PR fixes:

Fixes #596

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@xujiajiadexiaokeai
fix: dead-link-checker can't find out dead links (mosn#596)
46f2546 
update markdown-link-check version v3.8.7 -> v3

optimize check-dead-link result display

ignore internal anchor
@mosn-community-bot
Copy link

Hi @xujiajiadexiaokeai, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:no First-time contributor question Further information is requested size/M cla:yes and removed cla:no labels May 26, 2022
@codecov
Copy link

codecov bot commented May 27, 2022 •
edited
Loading

Codecov Report

Merging #609 (6529d1a) into main (c1fd81b) will not change coverage.
The diff coverage is n/a.

❗ Current head 6529d1a differs from pull request most recent head e1db3b4. Consider uploading reports for the commit e1db3b4 to get more accurate results

@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39dec2...e1db3b4. Read the comment docs.

@xujiajiadexiaokeai
Copy link
Contributor Author

image

image

@seeflood Hi! Shall we need to add [0, 403] to aliveStatusCodes?

@seeflood
Copy link
Member

seeflood commented May 27, 2022 •
edited
Loading

Thanks for your great contribution!
I don't know why the link https://techhenzy.com/proxy-webassembly-architecture/ returns 403. But we can add it to the ignore list, since I can open it with browser:
image

As for the image that returns status 0 , let's rerun the workflow to try again

Now the "status 0" problem disappeared :)

@xujiajiadexiaokeai
Copy link
Contributor Author

image

:) Cloudflare may rejected the request...hhh

@seeflood seeflood requested a review from Xunzhuo May 28, 2022 06:22
seeflood
seeflood approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!
By the way, your id is cute :)

@seeflood seeflood merged commit d991eba into mosn:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenxuwan wenxuwan wenxuwan approved these changes

@seeflood seeflood seeflood approved these changes

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees
No one assigned
Labels
bug Something isn't working cla:yes First-time contributor question Further information is requested size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: deadlink checker can't find out dead links
3 participants
@xujiajiadexiaokeai @seeflood @wenxuwan