New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support register listener filters. #1014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangfakang
requested review from
nejisama and
taoyuanyuan
and removed request for
nejisama
March 3, 2020 06:38
wangfakang
force-pushed
the
feature-listener
branch
from
March 3, 2020 10:01
b12e103
to
5d510cf
Compare
wangfakang
force-pushed
the
feature-listener
branch
from
March 3, 2020 13:59
5d510cf
to
0975090
Compare
wangfakang
force-pushed
the
feature-listener
branch
from
March 4, 2020 02:12
7a116a6
to
a9459d9
Compare
wangfakang
force-pushed
the
feature-listener
branch
from
March 4, 2020 02:51
a9459d9
to
351db67
Compare
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
+ Coverage 56.59% 56.62% +0.03%
==========================================
Files 238 238
Lines 22737 22786 +49
==========================================
+ Hits 12868 12903 +35
- Misses 8710 8722 +12
- Partials 1159 1161 +2
Continue to review full report at Codecov.
|
wangfakang
force-pushed
the
feature-listener
branch
from
March 6, 2020 03:50
351db67
to
e00ecfb
Compare
nejisama
reviewed
Mar 13, 2020
nejisama
reviewed
Mar 13, 2020
nejisama
reviewed
Mar 13, 2020
nejisama
reviewed
Mar 13, 2020
nejisama
reviewed
Mar 13, 2020
taoyuanyuan
reviewed
Mar 13, 2020
taoyuanyuan
reviewed
Mar 13, 2020
wangfakang
force-pushed
the
feature-listener
branch
from
March 13, 2020 10:39
a18143f
to
e2926c6
Compare
nejisama
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues associated with this PR
Support register listener filters, such as original_dst listener filter.
Note Need to merge #1005 first .
Solutions
Execution phase
When a new connection is received, MOSN's OnAccept execution process is triggered. The listener filter will execute before the connection instance created. As follows
Filter registration API
RegisterListener API is provided to RegisterListener filter instances. The listener filter instance only need to implement
ListenerFilterChainFactory
interface (such as realize OnAccept method) andListenerFilterFactoryCreator
type method for parse the filter configuration.Configuration
Support for both static and XDS configuration, such as
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style
Goimports
has runGolint
result