Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add start retry for sds client #1036

Merged
merged 3 commits into from Mar 11, 2020
Merged

add start retry for sds client #1036

merged 3 commits into from Mar 11, 2020

Conversation

pxzero
Copy link
Contributor

@pxzero pxzero commented Mar 11, 2020

Issues associated with this PR

Your PR should present related issues you want to solve.

Solutions

Add start retry for sds client init and support dynamic change sds config

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d846350). Click here to learn what that means.
The diff coverage is 36%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1036   +/-   ##
=========================================
  Coverage          ?   55.56%           
=========================================
  Files             ?      247           
  Lines             ?    23900           
  Branches          ?        0           
=========================================
  Hits              ?    13280           
  Misses            ?     9399           
  Partials          ?     1221
Impacted Files Coverage Δ
pkg/mtls/secret_manager.go 68.53% <0%> (ø)
pkg/mtls/sds/sdsclient.go 78.57% <100%> (ø)
pkg/mtls/sds/subscriber.go 54.28% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d846350...47fff7f. Read the comment docs.

@nejisama nejisama merged commit 562b50c into mosn:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants