Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peek timeout set to idle timeout #1040

Merged
merged 1 commit into from Mar 12, 2020
Merged

peek timeout set to idle timeout #1040

merged 1 commit into from Mar 12, 2020

Conversation

nejisama
Copy link
Contributor

Issues associated with this PR

Your PR should present related issues you want to solve.

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

Copy link
Contributor

@taoyuanyuan taoyuanyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1040 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
- Coverage   55.59%   55.58%   -0.01%     
==========================================
  Files         247      250       +3     
  Lines       23905    24023     +118     
==========================================
+ Hits        13290    13354      +64     
- Misses       9395     9446      +51     
- Partials     1220     1223       +3
Impacted Files Coverage Δ
pkg/network/connection.go 34.97% <ø> (ø) ⬆️
pkg/types/network.go 0% <ø> (ø) ⬆️
pkg/server/handler.go 40.53% <100%> (ø) ⬆️
pkg/mtls/conn.go 27.58% <50%> (ø) ⬆️
pkg/stream/stream.go 33.33% <0%> (-13.34%) ⬇️
pkg/module/http2/transport.go 78.47% <0%> (-0.15%) ⬇️
pkg/proxy/var.go 6.02% <0%> (ø) ⬆️
pkg/variable/factory.go 41.93% <0%> (ø)
pkg/variable/var.go 94.11% <0%> (ø)
pkg/variable/api.go 45.28% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d14d8...8a4d742. Read the comment docs.

@nejisama nejisama merged commit d2bb04b into mosn:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants