Adds integrated benchmarks for proxywasm #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
changed the title
This adds benchmarks for the only proxy-wasm compatible ABI available in mosn: v1. This is mainly an effort to help folks recognize the performance overhead and also how critical being incompatible is for the ecosystem. For example, the wasm in the below test only adds one header and nothing else. To do that takes over 60us. In comparison, other wasm handlers can do the same in 2-3us. ``` Benchmark_BaseCase-16 8696 133748 ns/op Benchmark_ProxyWasmV1-16 5760 195353 ns/op ``` Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
benchmark
branch
from
4163000
to
7a466df
Compare
Codecov ReportBase: 60.35% // Head: 60.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2164 +/- ##
==========================================
+ Coverage 60.35% 60.36% +0.01%
==========================================
Files 417 417
Lines 36583 36583
==========================================
+ Hits 22081 22085 +4
+ Misses 12319 12318 -1
+ Partials 2183 2180 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds benchmarks for the only proxy-wasm compatible ABI available in mosn: v1. This is mainly an effort to help folks recognize the performance overhead and also how critical being incompatible is for the ecosystem.
For example, the wasm in the below test only adds one header and nothing else. To do that takes over 60us. In comparison, other wasm handlers can do the same in single digit us even 2 or 3.
cc @Taction @taoyuanyuan @antJack