Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit-tests for NilMetrics #2312

Merged
merged 2 commits into from May 23, 2023
Merged

test: add unit-tests for NilMetrics #2312

merged 2 commits into from May 23, 2023

Conversation

jizhuozhi
Copy link
Contributor

@jizhuozhi jizhuozhi commented May 23, 2023

Issues associated with this PR

Add test cases for #2310

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (dcb0ff1) 60.54% compared to head (d016e04) 60.49%.

❗ Current head d016e04 differs from pull request most recent head 80eeffe. Consider uploading reports for the commit 80eeffe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2312      +/-   ##
==========================================
- Coverage   60.54%   60.49%   -0.06%     
==========================================
  Files         422      422              
  Lines       37477    37477              
==========================================
- Hits        22691    22670      -21     
- Misses      12549    12570      +21     
  Partials     2237     2237              

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taoyuanyuan taoyuanyuan added this to the 1.6.0 milestone May 23, 2023
@jizhuozhi jizhuozhi merged commit 5db6698 into mosn:master May 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants