Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShaderProgram: Add glUniform for single value calls using non-v variants #592

Closed
wants to merge 1 commit into from

Conversation

hugoam
Copy link

@hugoam hugoam commented Sep 13, 2022

After discussion in this issue: #591
Here is a draft of adding the setUniform calls mapping to non-v variants of glUniform functions :)

@hugoam hugoam marked this pull request as ready for review September 13, 2022 14:58
@mosra mosra added this to the 2022.0a milestone Sep 14, 2022
@mosra
Copy link
Owner

mosra commented Sep 14, 2022

So it was 16 variants after all, not 12 :) Thanks! I'll merge it ASAP, there isn't much else to do here.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #592 (6ba47d4) into master (eb382b3) will decrease coverage by 1.81%.
The diff coverage is 21.92%.

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   82.20%   80.38%   -1.82%     
==========================================
  Files         525      530       +5     
  Lines       36417    40738    +4321     
==========================================
+ Hits        29936    32748    +2812     
- Misses       6481     7990    +1509     
Impacted Files Coverage Δ
src/Magnum/GL/AbstractShaderProgram.cpp 26.02% <19.78%> (-14.97%) ⬇️
...rc/Magnum/GL/Implementation/ShaderProgramState.cpp 23.28% <27.27%> (-4.08%) ⬇️
src/Magnum/GL/AbstractShaderProgram.h 58.53% <100.00%> (-14.44%) ⬇️
src/Magnum/GL/Shader.h 40.74% <0.00%> (-50.17%) ⬇️
src/Magnum/GL/AbstractObject.h 50.00% <0.00%> (-50.00%) ⬇️
src/Magnum/Shaders/VectorGL.cpp 56.87% <0.00%> (-26.34%) ⬇️
src/Magnum/Shaders/PhongGL.cpp 55.08% <0.00%> (-24.58%) ⬇️
src/Magnum/GL/Implementation/ShaderState.cpp 52.63% <0.00%> (-24.30%) ⬇️
src/Magnum/Shaders/VertexColorGL.cpp 55.65% <0.00%> (-24.08%) ⬇️
src/Magnum/Shaders/FlatGL.cpp 62.66% <0.00%> (-23.53%) ⬇️
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mosra
Copy link
Owner

mosra commented Sep 14, 2022

Wow, the codecov reports are utter garbage. What is going on in there.

@mosra
Copy link
Owner

mosra commented Sep 14, 2022

Merged as 40d1326 (I did a rebase against latest master), thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants