Use a proper Schema Registry client to fix issues in #22 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add srclient dependency as a better way to access Schema Registry Combine functions in Avro serdes Change SchemaRegistryConfiguration and BasicAuth to fix issues (breaking change) Validate configuration for all supported (and unsupported) serde functionlity Default serde is now StringSerializer and StringDeserializer Refactor wire format de/encoding Fix bugs, typos and refactor the rest
This was referenced May 8, 2022
Closed
mostafa
added a commit
that referenced
this pull request
May 31, 2022
* Use a proper Schema Registry client to fix issues in #22 * Add srclient dependency as a better way to access Schema Registry * Combine functions in Avro serdes * Change SchemaRegistryConfiguration and BasicAuth to fix issues (breaking change) * Validate configuration for all supported (and unsupported) serde functionality * Default serde is now StringSerializer and StringDeserializer * Refactor wire format de/encoding * Fix bugs and typos and refactor the rest * Refactor basic auth function and move structs to their relevant files * Fix linting errors reported by gosimple (golangci-lint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I've introduced a new dependency (https://github.com/riferrei/srclient) by @riferrei 馃檹 to fix issues reported in #22 (by @saad1200 and @ssam5532). By doing so, I've also refactored most of the code related to serdes functionality and created a few tickets along the way:
Breaking changes
I've broken backward compatibility with the schema registry client configuration object.
Issues
getSchemafunction retrieves the latest version of the schema from Schema Registery, so I created an issue to make it optional by users@saad1200 and @ssam5532
I have tested it with
test_json.jsandtest_avro_with_schema_registry.js,and I'd be happy to have your feedback.