Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return boolean values instead of "true"/"false" strings. #247

Closed
wants to merge 1 commit into from
Closed

Return boolean values instead of "true"/"false" strings. #247

wants to merge 1 commit into from

Commits on Nov 28, 2017

  1. Return boolean values instead of "true"/"false" strings. 

    When boolean values are set in an .env file (e.g. IS_PRODUCTION=false), it's expected that these will be evalulated as booleans, instead of the string "false" (which is truthy).  This causes particular problems when using webpack and webpack.DefinePlugin, since providing `JSON.stringify(process.env.IS_PRODUCTION` will evaluate as a string, which is unexpected.

Instead, change `"true"` to `true` and `"false"` to `false` when evaluating the .env file.
    @becdot
    becdot committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    27cfacf View commit details
    Browse the repository at this point in the history