-
-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return boolean values instead of "true"/"false" strings. #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becdot
force-pushed
the
becdot_eval_booleans
branch
from
November 28, 2017 23:08
a226ac2
to
9a49866
Compare
becdot
force-pushed
the
becdot_eval_booleans
branch
from
November 28, 2017 23:16
9a49866
to
d5442f9
Compare
1 similar comment
When boolean values are set in an .env file (e.g. IS_PRODUCTION=false), it's expected that these will be evalulated as booleans, instead of the string "false" (which is truthy). This causes particular problems when using webpack and webpack.DefinePlugin, since providing `JSON.stringify(process.env.IS_PRODUCTION` will evaluate as a string, which is unexpected. Instead, change `"true"` to `true` and `"false"` to `false` when evaluating the .env file.
becdot
force-pushed
the
becdot_eval_booleans
branch
from
November 28, 2017 23:18
d5442f9
to
27cfacf
Compare
Thanks but we keep them as strings to align with how
envalid will do type conversion for you or you could write your own module focused on boolean behavior. dotenv.config()
convertBooleans(process.env) |
That makes sense -- thanks for the explanation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When boolean values are set in an .env file (e.g.
IS_PRODUCTION=false
), it's expected that these will be evalulated as booleans, instead of the string"false"
(which is actually truthy). This causes particular problems when using webpack and webpack.DefinePlugin, since providingJSON.stringify(process.env.IS_PRODUCTION)
will evaluate as truthy, which is unexpected.Instead, change
"true"
totrue
and"false"
tofalse
when parsing the .env file.