Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests #279

Merged
merged 7 commits into from
Feb 26, 2018
Merged

Upgrade tests #279

merged 7 commits into from
Feb 26, 2018

Conversation

maxbeatty
Copy link
Contributor

@maxbeatty maxbeatty commented Feb 26, 2018

@coveralls
Copy link

coveralls commented Feb 26, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling de4eafb on upgrade-tests into 472db2e on master.

Max Beatty added 2 commits February 26, 2018 12:21
hunch that extending global object in Windows environment is not working
properly
jobs:
include:
- stage: coverage
node_js: 8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should try to keep this aligned with current LTS version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To automatically stay updated with the latest LTS version, you can use 'lts/*', as described here.

@maxbeatty maxbeatty mentioned this pull request Feb 26, 2018
@maxbeatty maxbeatty merged commit f62b70f into master Feb 26, 2018
@maxbeatty maxbeatty deleted the upgrade-tests branch February 26, 2018 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing tests on Windows 7 Pro SP1
3 participants