New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify unit tests #501

Merged

DeviaVir merged 2 commits into motdotla:master from abetomo:fix_test_log

Sep 25, 2019

Contributor

abetomo commented Sep 11, 2019

Stop disabling logs during unit tests
- Node.js 12 seems to be unable to use this trick.
Fixed output test
- Because the output of console.log has changed in Node.js 12.

abetomo added 2 commits

September 11, 2019 00:54


          Stop disabling logs during unit tests

fe83e74

Node.js 12 seems to be unable to use this trick.


          Fixed output test

a2388f2

Because the output of console.log has changed in Node.js 12.

DeviaVir approved these changes

View reviewed changes

DeviaVir merged commit 393ec32 into motdotla:master

abetomo deleted the fix_test_log branch

September 25, 2019 09:06

Contributor Author

abetomo commented Sep 25, 2019

Thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet