Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Motioneye Python3 Work #1978

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

herostrat
Copy link
Contributor

No description provided.

@ccrisan
Copy link
Collaborator

ccrisan commented Dec 26, 2020

@herostrat I don't think there's any point in using list(...) when iterating over dictionary items (i.e. when used in one of the for-loop constructions).

@herostrat
Copy link
Contributor Author

I agree, I changed it after the suggestion of 2to3 and wanted to check if (and why) there it showed the suggestion.

In this case I could not find a difference in behavior, so at least it does not regress, although I don't understand why it should be changed in the first place.

I will revert those changes before I submit it for review.

@MichaIng
Copy link
Member

MichaIng commented May 1, 2021

Just to avoid doubled work, there is another PR open about this already: #1805

Looking forward for this, as of Python 2 deprecation, making it increasingly difficult / unreasonable to keep supporting Python 2 dependant software.

@mweinelt
Copy link

mweinelt commented May 6, 2021

Just to avoid doubled work, there is another PR open about this already: #1805

The problem with the other pull request is, that it is too big too review, test and merge properly. So I think it would be better to get small changes into the python3 branch again and again, so the volume of changes remains reviewable.

@MichaIng MichaIng added the python update python 2 > python 3 label Mar 8, 2022
@MichaIng MichaIng changed the base branch from python3 to dev March 9, 2022 19:14
@MichaIng
Copy link
Member

MichaIng commented Mar 9, 2022

I rebased the PR and resolved conflicts, and this is now mostly obsolete, as solved in current dev already 🙂. I'll merge it however to have the trailing spaces removed 😉.

@MichaIng MichaIng merged commit 533cc76 into motioneye-project:dev Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python update python 2 > python 3
Development

Successfully merging this pull request may close these issues.

None yet

4 participants