Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Costom Hotkey do not work with safari 12.0.1 #64

Closed
chenshengzhi opened this issue Nov 25, 2018 · 5 comments
Closed

Github Costom Hotkey do not work with safari 12.0.1 #64

chenshengzhi opened this issue Nov 25, 2018 · 5 comments

Comments

@chenshengzhi
Copy link

Github Costom Hotkey do not work with safari 12.0.1

@Mottie
Copy link
Owner

Mottie commented Nov 25, 2018

Hi @chenshengzhi!

All the custom hotkey script does is adds a link with a data-hotkey attribute set with your customizations, e.g.:

<a class="ghch-link" href="https://github.com/Mottie/GitHub-userscripts/pulse" data-hotkey="g p"></a>

WIth the above example, pressing g then p will activate GitHub's built-in script to go to the link's href which is the repo's pulse page.

If this is a specific problem in Safari, then try some of GitHub's other hotkeys (press ? to see them) and if they don't work, then I would report the issue to GitHub support.

@Neil20170220
Copy link

Neil20170220 commented Nov 26, 2018

Thank you for your reply!

Sorry, I did not describe the situation clearly.
20181126093257

  1. The setting entry do not showing when i tap my avatar.
  2. I try install another scrip GitHub custom navigation, but failed again.
  3. TamperMonkey show they are running.
    20181126093605
  4. Github's built-in hotkeys works fine.

@chenshengzhi
Copy link
Author

I test using script:

// ==UserScript==
// @name         Test
// @namespace    http://tampermonkey.net/
// @version      0.1
// @description  try to take over the world!
// @author       You
// @include      *://*github.com/*
// @include      *://*.google*/*
// @grant        none
// ==/UserScript==

(function () {
    console.log("test test test test test ");
})()

I see the log in Google, but not in Github.
@Mottie can you help me? Thanks!

@Mottie
Copy link
Owner

Mottie commented Nov 28, 2018

I don't own any apple products, so I'm not able to use safari... either way, this sounds like it's an issue with Tampermonkey. Please report the problem here: https://github.com/Tampermonkey/tampermonkey/issues

@chenshengzhi
Copy link
Author

OK, Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants