Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swap sip import order for pyqt5 to account for compat w private … #334

Merged
merged 2 commits into from
Feb 10, 2020
Merged

fix: swap sip import order for pyqt5 to account for compat w private … #334

merged 2 commits into from
Feb 10, 2020

Conversation

maxnbk
Copy link
Contributor

@maxnbk maxnbk commented Feb 5, 2020

…module names in 5.11+

for issue #333

@claassistantio
Copy link

claassistantio commented Feb 5, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@mottosso
Copy link
Owner

mottosso commented Feb 6, 2020

Thanks @maxnbk, this looks solid. Would you mind bumping the version to 1.2.4? That way I can make a release with this fix.

@maxnbk
Copy link
Contributor Author

maxnbk commented Feb 7, 2020

version bumped.

@mottosso
Copy link
Owner

Thanks!

@mottosso mottosso merged commit 4bcc646 into mottosso:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxnbk @claassistantio @mottosso