Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the module name that failed to import in warning #350

Merged

Conversation

MHendricks
Copy link
Collaborator

On windows, if a required dll is missing you get the exception message DLL load failed: The specified module could not be found..
This makes means that you have to test each import manually so you can debug the problem.

This pull request adds the name of the module that failed to import to the warning.

Old: Qt.py [warning]: ImportError: DLL load failed: The specified module could not be found.
New: Qt.py [warning]: ImportError(QtXmlPatterns): DLL load failed: The specified module could not be found.

@mottosso
Copy link
Owner

mottosso commented Oct 2, 2020

Nice one. :) Could you version this to 1.3.2 and I'll make a new release?

@MHendricks MHendricks force-pushed the import_error_warning_improvement branch from b3413da to defede1 Compare October 2, 2020 22:01
@MHendricks
Copy link
Collaborator Author

Version updated

@mottosso mottosso merged commit 8a8953b into mottosso:master Oct 3, 2020
@mottosso
Copy link
Owner

mottosso commented Oct 3, 2020

Released, thanks @MHendricks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants