-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synching up to changes made in agenda 0.7.2. #17
Conversation
-Added better error checking in constructor.
@3choBoomer thanks!, @moudy can you please merge this? thanks! |
@moudy @esteban-uo @3choBoomer can you please merge this? |
👍 |
@liamdon Hey Liam 😄 nice to see you here! Hope ClassDojo is going well. |
There is only one working use case with this pull request: var agenda = new Agenda({ mongo: myMongoClientConnection }); This does not work: var agenda = new Agenda({ db: { address: myDBURIString, collection: 'agendaJobs'} }); @3choBoomer can we get this patched to support this usage too? |
This is the error we get if we don't use
|
need that one to be merged please |
+1, please merge :) |
+1, merge please |
Having this check breaks other ways of creating Agenda instances.
@niftylettuce done. |
thanks, just needs merged now |
we need @moudy to do that. |
@3choBoomer sorry just seeing this now, thanks! |
Synching up to changes made in agenda 0.7.2.
@3choBoomer having trouble getting the project to build so can't publish to NPM yet... will try to find time to debug soon. |
-Added better error checking in constructor.
Agenda 0.7.2 renamed _db to _collection to better match what the variable actually holds.