Restore qwebelement rtti #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnutt
force-pushed
the
restore-qwebelement-rtti
branch
from
9223914
to
64055fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2caecbb we disabled rtti for QWebElement in order to get the build working, but this broke API compatibility for users.
The issue is that QtWebKit exposes runtime type information in its API, but WebKit/WebCore has rtti disabled (via
-fno-rtti). With QWebElement calling into WebCore/JSC viaevaluateJavaScript, we get linking errors due to missing typeinfo forJSC::SourceProvider.This PR splits out the code that creates the
JSC::SourceProviderinto a separate source file (EvaluateJS.cpp) which does not have rtti disabled.