Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake such that Boost::filesystem is exported properly #205

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Fix cmake such that Boost::filesystem is exported properly #205

merged 1 commit into from
Nov 1, 2021

Conversation

jlack1987
Copy link

@jlack1987 jlack1987 commented Oct 28, 2021

This fixes #166. Ultimately this issue result in the Boost components not getting exported with an ament_target_dependencies and ament_export_dependencies calls.

Before this fix attempting to link against this pkg resulted in,

Target "mylib" links to target "Boost::filesystem"
  but the target was not found.  Perhaps a find_package() call is missing for
  an IMPORTED target, or an ALIAS target is missing?

After this fix it builds properly.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. Small nit: could you rename the cmake file to "ConfigExtras.cmake" and also include it to replace find_package(Boost.. )? Mostly for consistency with the other packages and to keep Boost dependencies in a single spot.

@jlack1987
Copy link
Author

@henningkayser I went ahead and fixed the file name, but I don't think that file should be included. Is there somewhere else you have seen that does this?

@JafarAbdi JafarAbdi merged commit acce3f8 into moveit:ros2 Nov 1, 2021
@jlack1987
Copy link
Author

Is there any chance this could get cherry picked into foxy/galactic since it's a bug that makes it tough to use this package?

@JafarAbdi
Copy link

For some reason, GitHub decided to merge this PR by me only pushing to your branch :/

@JafarAbdi
Copy link

@jlack1987 Do you mind testing the latest ros2 branch .?

@JafarAbdi
Copy link

JafarAbdi commented Nov 1, 2021

Is there any chance this could get cherry picked into foxy/galactic since it's a bug that makes it tough to use this package?

Yep, I'll do right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants