Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Planning Tab ~Remember open tab in RViz panel~ #2061

Closed
v4hn opened this issue May 7, 2020 · 5 comments
Closed

Default to Planning Tab ~Remember open tab in RViz panel~ #2061

v4hn opened this issue May 7, 2020 · 5 comments
Labels
bug moveit day candidate This issue can likely be resolved in less than a day

Comments

@v4hn
Copy link
Contributor

v4hn commented May 7, 2020

Since #1991 a lot of state in the Motion Planning display in rviz is saved.
The currently open tab of the display panel (Context, Planning, Scene Objects...) is not saved though.

Did you leave that out on purpose @rhaschke ?

I would prefer to end up in the Planning tab for most of my configurations, so I'm interested in saving this too.

@v4hn v4hn added bug moveit day candidate This issue can likely be resolved in less than a day labels May 7, 2020
@rhaschke
Copy link
Contributor

rhaschke commented May 7, 2020

I kind of left that out on purpose, yes. I think we should just default the planning tab (instead of the first one).

@v4hn
Copy link
Contributor Author

v4hn commented May 7, 2020 via email

@gavanderhoorn
Copy link
Contributor

But that way, most users would probably never look at any of the other tabs and selecting different planning algorithms & parameterizations is in theory one of the main selling points of the framework.

Personally I'm not sure there is a "best" option here: if users always see the first tab on startup, they may never look at the others. If we save MoveIt configuration pkgs with any tab but the first active, and this is persisted and restored, users may have trouble finding the tab described "everywhere" (ie: the first one).

@felixvd
Copy link
Contributor

felixvd commented May 7, 2020

I think the tabs are sufficiently discoverable without forcing an extra click on every startup, so I'm in favor of defaulting to the Planning tab.

There's a larger discussion to be had about the selling points of the framework, but I suspect that comparing different motion planning algorithms isn't at the forefront anymore necessarily. Prototyping, production and overall usability seem to be becoming more and more important.

@v4hn v4hn changed the title Remember open tab in RViz panel Default to Planning Tab -Remember open tab in RViz panel- May 11, 2020
@v4hn v4hn changed the title Default to Planning Tab -Remember open tab in RViz panel- Default to Planning Tab ~Remember open tab in RViz panel~ May 11, 2020
@rhaschke
Copy link
Contributor

#2198 defines the planning tab as default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug moveit day candidate This issue can likely be resolved in less than a day
Projects
None yet
Development

No branches or pull requests

4 participants