Fix QObject::connect: Cannot queue arguments of type 'QVector<int>' #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caused by accessing/updating GUI elements from a non-GUI thread
This comment has been minimized.
This comment has been minimized.
tylerjw
approved these changes
Oct 24, 2020
...lanning_scene_rviz_plugin/include/moveit/planning_scene_rviz_plugin/planning_scene_display.h
Outdated
Show resolved
Hide resolved
rhaschke
changed the title
rhaschke
changed the title
|
@simonschmeisser, I addressed your feedback. Thanks for pointing me to |
| scene_name_property_->setStdString(getPlanningSceneRO()->getName()); | ||
| scene_name_property_->blockSignals(old_state); | ||
|
|
||
| QMetaObject::invokeMethod(this, "setSceneName", Qt::QueuedConnection, |
There was a problem hiding this comment.
Suggested change
| QMetaObject::invokeMethod(this, "setSceneName", Qt::QueuedConnection, | |
| QMetaObject::invokeMethod(this, &PlanningSceneDisplay::setSceneName, Qt::QueuedConnection, |
probably doesn't work due to the argument right?
There was a problem hiding this comment.
Yeah, tried this first. But invokeMethod doesn't support methods, only lambdas.
simonschmeisser
approved these changes
Oct 27, 2020
Closed
tylerjw
pushed a commit
to tylerjw/moveit
that referenced
this pull request
Apr 29, 2021
Merged
tylerjw
pushed a commit
to tylerjw/moveit
that referenced
this pull request
May 3, 2021
tylerjw
pushed a commit
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix annoying Qt warning about unregistered
QVector<int>. The reason was that the planning scene name was changed from a non-GUI thread, causing adataChanged()signal emitted from this thread, which then needs to be queued for processing in the main event loop.I fixed that by emitting a signal from the thread to change the name. Thus, a
QStringevent is queued, which doesn't pose an issue.