Servo: protect paused_ flag, for thread safety #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyZe
changed the title
AndyZe
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2494 +/- ##
==========================================
- Coverage 60.26% 60.26% -0.00%
==========================================
Files 351 351
Lines 26477 26477
==========================================
- Hits 15955 15954 -1
- Misses 10522 10523 +1
Continue to review full report at Codecov.
|
|
This is failing Travis due to docker pull limits: https://travis-ci.com/github/ros-planning/moveit/jobs/473939663 We have this issue to track this problem: #2493 I don't know when I'll have time to work on this. If anyone has the capacity to figure it out I'd appreciate it. @nbbrooks |
|
^At least it's only 5 bucks a month to get unlimited Docker pulls |
Closed
tylerjw
pushed a commit
to tylerjw/moveit
that referenced
this pull request
Apr 29, 2021
Merged
tylerjw
pushed a commit
to tylerjw/moveit
that referenced
this pull request
May 3, 2021
tylerjw
pushed a commit
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MoveIt Servo I was calling
setPaused()from another thread while printing the value ofpaused_here in ServoCalcs. And I saw that it often didn't change. This fixes it.