Servo: Do not break out of loop -- need to update low pass filters #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyZe
force-pushed
the
andyz/dont_short_circuit_servo
branch
from
e6a26bb
to
6212c65
Compare
tylerjw
approved these changes
Jan 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #2496 +/- ##
==========================================
- Coverage 60.26% 60.25% -0.01%
==========================================
Files 351 351
Lines 26477 26476 -1
==========================================
- Hits 15955 15951 -4
- Misses 10522 10525 +3
Continue to review full report at Codecov.
|
Closed
tylerjw
pushed a commit
to tylerjw/moveit
that referenced
this pull request
Apr 29, 2021
Merged
tylerjw
pushed a commit
to tylerjw/moveit
that referenced
this pull request
May 3, 2021
tylerjw
pushed a commit
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implemented this short circuit for efficiency, but in the case of
stop_requested_we want to continue updating the current robot state and the low pass filters. This prevents a jerk from occurring when Servoing resumes.