Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servo: add missing include #2519

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Feb 16, 2021

The code uses std::atomic<bool> further below, but relies on other headers including it.
It's not always there though. Compiling failed for me on Lunar-Linux with ROS melodic.

@v4hn v4hn requested a review from rhaschke as a code owner February 16, 2021 12:38
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #2519 (028ea1c) into master (ea50801) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2519      +/-   ##
==========================================
- Coverage   60.30%   60.26%   -0.03%     
==========================================
  Files         351      351              
  Lines       26471    26471              
==========================================
- Hits        15960    15951       -9     
- Misses      10511    10520       +9     
Impacted Files Coverage Δ
moveit_core/robot_model/src/joint_model_group.cpp 63.08% <0.00%> (-2.46%) ⬇️
...e/src/parameterization/model_based_state_space.cpp 70.40% <0.00%> (-2.39%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.55% <0.00%> (+0.45%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 72.96% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea50801...e92fa1d. Read the comment docs.

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndyZe AndyZe merged commit e986f6d into moveit:master Feb 16, 2021
@tylerjw tylerjw mentioned this pull request Apr 9, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Apr 29, 2021
@tylerjw tylerjw mentioned this pull request Apr 29, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request May 3, 2021
tylerjw pushed a commit that referenced this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants