Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msa: fix segfault #2564

Merged
merged 1 commit into from
Mar 25, 2021
Merged

msa: fix segfault #2564

merged 1 commit into from
Mar 25, 2021

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Mar 25, 2021

happened when a group was defined in the launch file without a ns attribute.

happened when a group was defined in the launch file without a `ns` attribute.
@v4hn v4hn requested a review from rhaschke as a code owner March 25, 2021 13:00
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2564 (9a5c4e6) into master (460c152) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head 9a5c4e6 differs from pull request most recent head 5dc271d. Consider uploading reports for the commit 5dc271d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
- Coverage   60.21%   60.14%   -0.06%     
==========================================
  Files         351      351              
  Lines       26575    26576       +1     
==========================================
- Hits        16000    15982      -18     
- Misses      10575    10594      +19     
Impacted Files Coverage Δ
...t_setup_assistant/src/tools/moveit_config_data.cpp 19.19% <0.00%> (-0.02%) ⬇️
.../ompl_interface/src/detail/constrained_sampler.cpp 42.86% <0.00%> (-17.14%) ⬇️
moveit_core/robot_model/src/joint_model_group.cpp 63.08% <0.00%> (-2.46%) ⬇️
...e/src/parameterization/model_based_state_space.cpp 70.40% <0.00%> (-2.39%) ⬇️
...on/pick_place/src/approach_and_translate_stage.cpp 72.14% <0.00%> (-0.81%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 84.56% <0.00%> (-0.73%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.11% <0.00%> (-0.44%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 67.62% <0.00%> (+0.16%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 73.41% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460c152...5dc271d. Read the comment docs.

@felixvd felixvd merged commit cd91cd1 into moveit:master Mar 25, 2021
@felixvd
Copy link
Contributor

felixvd commented Mar 25, 2021

Should be backported as far as I can see.

@tylerjw tylerjw mentioned this pull request Apr 9, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Apr 29, 2021
Occurred when a group was defined in the launch file without a `ns` attribute.
@tylerjw tylerjw mentioned this pull request Apr 29, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request May 3, 2021
Occurred when a group was defined in the launch file without a `ns` attribute.
tylerjw pushed a commit that referenced this pull request May 3, 2021
Occurred when a group was defined in the launch file without a `ns` attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants