Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint visualization #1141

Merged
merged 5 commits into from Oct 25, 2018
Merged

Lint visualization #1141

merged 5 commits into from Oct 25, 2018

Conversation

Chamango90
Copy link

@Chamango90 Chamango90 commented Oct 25, 2018 •
edited

Attempt to catkin_lint the package moveit_ros_visualization :

moveit_ros_visualization: error: missing build_depend on 'rosconsole'
moveit_ros_visualization: error: missing build_depend on 'class_loader'
moveit_ros_visualization: error: missing build_depend on 'eigen_conversions'
moveit_ros_visualization: error: missing build_depend on 'tf'
moveit_ros_visualization: error: catkin_package() exports package include path that is not installed
moveit_ros_visualization: error: unconfigured build_depend on 'rospy'
moveit_ros_visualization: error: unconfigured build_depend on 'pluginlib'
moveit_ros_visualization: CMakeLists.txt(119): error: duplicate find_package(rostest)
moveit_ros_visualization: warning: package 'object_recognition_msgs' should be listed in catkin_package()
moveit_ros_visualization: CMakeLists.txt(19): warning: use of link_directories() is strongly discouraged
moveit_ros_visualization: CMakeLists.txt(100): warning: use of link_directories() is strongly discouraged
moveit_ros_visualization: CMakeLists.txt(101): warning: use of link_directories() is strongly discouraged
moveit_ros_visualization: motion_planning_rviz_plugin/CMakeLists.txt(35): warning: install(DIRECTORY ... DESTINATION) is not one of the ${CATKIN_*_DESTINATION}s
moveit_ros_visualization: planning_scene_rviz_plugin/CMakeLists.txt(13): warning: install(DIRECTORY ... DESTINATION) is not one of the ${CATKIN_*_DESTINATION}s
moveit_ros_visualization: robot_state_rviz_plugin/CMakeLists.txt(14): warning: install(DIRECTORY ... DESTINATION) is not one of the ${CATKIN_*_DESTINATION}s
moveit_ros_visualization: rviz_plugin_render_tools/CMakeLists.txt(34): warning: install(DIRECTORY ... DESTINATION) is not one of the ${CATKIN_*_DESTINATION}s
moveit_ros_visualization: trajectory_rviz_plugin/CMakeLists.txt(27): warning: install(DIRECTORY ... DESTINATION) is not one of the ${CATKIN_*_DESTINATION}s
catkin_lint: checked 1 packages and found 17 problems
catkin_lint: 14 notices have been ignored. Use -W2 to see them

The warning

moveit_ros_visualization: CMakeLists.txt(19): warning: use of link_directories() is strongly discouraged

is not "solved", since not clear if link_directories( ${OGRE_LIBRARY_DIRS} ) is required.

Missing

  • Decide if this should be cherry-picked to other current ROS branches

dhled
dhled reviewed Oct 25, 2018
View reviewed changes
Copy link

@dhled dhled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, then I might also integrate this in mine. Thank you !

rhaschke
rhaschke approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

moveit_ros/visualization/CMakeLists.txt
@@ -19,20 +19,21 @@ pkg_check_modules(OGRE OGRE)
link_directories( ${OGRE_LIBRARY_DIRS} )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is indeed needed, as pkg-config only reports -lOgreMain -lpthread only.

@davetcoleman davetcoleman merged commit 9dba172 into moveit:kinetic-devel Oct 25, 2018
davetcoleman pushed a commit to davetcoleman/moveit that referenced this pull request Oct 25, 2018
@Chamango90 @davetcoleman
Lint visualization (moveit#1141)
68c08c2 
* Sort dependencies alphabetically

* Add missing dependencies

* Fix rostest deps

* Use CATKIN_GLOBAL_INCLUDE_DESTINATION

* Remove link_directories
@davetcoleman davetcoleman mentioned this pull request Oct 25, 2018
Merged
@davetcoleman
Copy link
Member

#1144

pull bot pushed a commit to shadow-robot/moveit that referenced this pull request Sep 3, 2020
@Chamango90 @pull
Lint visualization (moveit#1141)
2f88471 
* Sort dependencies alphabetically

* Add missing dependencies

* Fix rostest deps

* Use CATKIN_GLOBAL_INCLUDE_DESTINATION

* Remove link_directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhled dhled dhled left review comments

@davetcoleman davetcoleman davetcoleman approved these changes

@rhaschke rhaschke rhaschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chamango90 @davetcoleman @rhaschke @dhled