Skip to content

Commit

Permalink
Remove unnecessary TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
sjahr committed Aug 31, 2022
1 parent 9dcb195 commit 82901cc
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions moveit_ros/planning/moveit_cpp/src/planning_component.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ PlanningComponent::PlanSolution PlanningComponent::plan(const PlanRequestParamet
req.workspace_parameters = workspace_parameters_;

// Set start state
moveit::core::RobotStatePtr start_state = considered_start_state_; // TODO pass as function argument
moveit::core::RobotStatePtr start_state = considered_start_state_;
if (!start_state)
start_state = moveit_cpp_->getCurrentState();
start_state->update();
Expand All @@ -169,17 +169,15 @@ PlanningComponent::PlanSolution PlanningComponent::plan(const PlanRequestParamet
}
return *plan_solution;
}
req.goal_constraints = current_goal_constraints_; // TODO pass as function argument

req.goal_constraints = current_goal_constraints_;
// Set path constraints
req.path_constraints = current_path_constraints_;
// Set trajectory constraints
req.trajectory_constraints = current_trajectory_constraints_;

// Run planning attempt
::planning_interface::MotionPlanResponse res;
if (planning_pipeline_names_.find(parameters.planning_pipeline) ==
planning_pipeline_names_.end()) // TODO pass as function argument
if (planning_pipeline_names_.find(parameters.planning_pipeline) == planning_pipeline_names_.end())
{
RCLCPP_ERROR(LOGGER, "No planning pipeline available for name '%s'", parameters.planning_pipeline.c_str());
plan_solution->error_code = moveit::core::MoveItErrorCode::FAILURE;
Expand Down

0 comments on commit 82901cc

Please sign in to comment.