[MSA] Virtual Destructors (#1324)

moveit · Jun 7, 2022 · 91e6f17 · 91e6f17
1 parent 4f3b718
commit 91e6f17
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/config.hpp b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/config.hpp
@@ -57,6 +57,8 @@ MOVEIT_CLASS_FORWARD(SetupConfig);  // Defines SetupConfigPtr, ConstPtr, WeakPtr
 class SetupConfig
 {
 public:
+  virtual ~SetupConfig() = default;
+
   /**
    * @brief Called after construction to initialize the step
    * @param config_data Pointer to all the other configs

diff --git a/..._setup_assistant/moveit_setup_framework/include/moveit_setup_framework/generated_file.hpp b/..._setup_assistant/moveit_setup_framework/include/moveit_setup_framework/generated_file.hpp
@@ -71,6 +71,8 @@ class GeneratedFile : public std::enable_shared_from_this<GeneratedFile>
   {
   }
 
+  virtual ~GeneratedFile() = default;
+
   /**
    * @brief Returns the path relative to the configuration package root
    */

diff --git a/..._assistant/moveit_setup_framework/include/moveit_setup_framework/qt/setup_step_widget.hpp b/..._assistant/moveit_setup_framework/include/moveit_setup_framework/qt/setup_step_widget.hpp
@@ -49,6 +49,8 @@ class SetupStepWidget : public QWidget
 {
   Q_OBJECT
 public:
+  virtual ~SetupStepWidget() = default;
+
   /**
    * @brief Called after construction to initialize the step
    * @param parent_node Shared pointer to the parent node

diff --git a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/setup_step.hpp b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/setup_step.hpp
@@ -46,6 +46,8 @@ namespace moveit_setup
 class SetupStep
 {
 public:
+  virtual ~SetupStep() = default;
+
   /**
    * @brief Called after construction to initialize the step
    * @param parent_node Shared pointer to the parent node