Merge branch 'main' into totg_issue

moveit · Jan 3, 2024 · bf436c3 · bf436c3
2 parents 8f3f9d0 + be8d3eb
commit bf436c3
Show file tree

Hide file tree

Showing 13 changed files with 98 additions and 29 deletions.
diff --git a/moveit_configs_utils/moveit_configs_utils/launches.py b/moveit_configs_utils/moveit_configs_utils/launches.py
@@ -327,9 +327,11 @@ def generate_demo_launch(moveit_config):
             package="controller_manager",
             executable="ros2_control_node",
             parameters=[
-                moveit_config.robot_description,
                 str(moveit_config.package_path / "config/ros2_controllers.yaml"),
             ],
+            remappings=[
+                ("/controller_manager/robot_description", "/robot_description"),
+            ],
         )
     )
 

diff --git a/moveit_core/collision_detection/CMakeLists.txt b/moveit_core/collision_detection/CMakeLists.txt
@@ -17,6 +17,7 @@ include(GenerateExportHeader)
 generate_export_header(moveit_collision_detection)
 
 ament_target_dependencies(moveit_collision_detection
+  pluginlib
   rclcpp
   rmw_implementation
   urdf

diff --git a/moveit_planners/test_configs/prbt_moveit_config/launch/demo.launch.py b/moveit_planners/test_configs/prbt_moveit_config/launch/demo.launch.py
@@ -189,7 +189,10 @@ def generate_launch_description():
     ros2_control_node = Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )
 

diff --git a/moveit_planners/test_configs/prbt_support/urdf/prbt.ros2_control.xacro b/moveit_planners/test_configs/prbt_support/urdf/prbt.ros2_control.xacro
@@ -21,9 +21,15 @@
 					<param name="min">-3.15</param>
 					<param name="max">3.15</param>
 				</command_interface>
-				<state_interface name="position"/>
-				<state_interface name="velocity"/>
-				<state_interface name="effort"/>
+				<state_interface name="position">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="velocity">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="effort">
+					<param name="initial_value">0.0</param>
+				</state_interface>
 				<param name="initial_position">${initial_positions['joint_1']}</param>  <!-- initial position for the FakeSystem -->
 			</joint>
 			<joint name="${prefix}joint_2">
@@ -35,9 +41,15 @@
 					<param name="min">-3.15</param>
 					<param name="max">3.15</param>
 				</command_interface>
-				<state_interface name="position"/>
-				<state_interface name="velocity"/>
-				<state_interface name="effort"/>
+				<state_interface name="position">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="velocity">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="effort">
+					<param name="initial_value">0.0</param>
+				</state_interface>
 				<param name="initial_position">${initial_positions['joint_2']}</param>  <!-- initial position for the FakeSystem -->
 			</joint>
 			<joint name="${prefix}joint_3">
@@ -49,9 +61,15 @@
 					<param name="min">-3.15</param>
 					<param name="max">3.15</param>
 				</command_interface>
-				<state_interface name="position"/>
-				<state_interface name="velocity"/>
-				<state_interface name="effort"/>
+				<state_interface name="position">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="velocity">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="effort">
+					<param name="initial_value">0.0</param>
+				</state_interface>
 				<param name="initial_position">${initial_positions['joint_3']}</param>  <!-- initial position for the FakeSystem -->
 			</joint>
 			<joint name="${prefix}joint_4">
@@ -63,9 +81,15 @@
 					<param name="min">-3.15</param>
 					<param name="max">3.15</param>
 				</command_interface>
-				<state_interface name="position"/>
-				<state_interface name="velocity"/>
-				<state_interface name="effort"/>
+				<state_interface name="position">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="velocity">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="effort">
+					<param name="initial_value">0.0</param>
+				</state_interface>
 				<param name="initial_position">${initial_positions['joint_4']}</param>  <!-- initial position for the FakeSystem -->
 			</joint>
 			<joint name="${prefix}joint_5">
@@ -77,9 +101,15 @@
 					<param name="min">-3.15</param>
 					<param name="max">3.15</param>
 				</command_interface>
-				<state_interface name="position"/>
-				<state_interface name="velocity"/>
-				<state_interface name="effort"/>
+				<state_interface name="position">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="velocity">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="effort">
+					<param name="initial_value">0.0</param>
+				</state_interface>
 				<param name="initial_position">${initial_positions['joint_5']}</param>  <!-- initial position for the FakeSystem -->
 			</joint>
 			<joint name="${prefix}joint_6">
@@ -91,9 +121,15 @@
 					<param name="min">-3.15</param>
 					<param name="max">3.15</param>
 				</command_interface>
-				<state_interface name="position"/>
-				<state_interface name="velocity"/>
-				<state_interface name="effort"/>
+				<state_interface name="position">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="velocity">
+					<param name="initial_value">0.0</param>
+				</state_interface>
+				<state_interface name="effort">
+					<param name="initial_value">0.0</param>
+				</state_interface>
 				<param name="initial_position">${initial_positions['joint_6']}</param>  <!-- initial position for the FakeSystem -->
 			</joint>
 		</ros2_control>

diff --git a/moveit_ros/hybrid_planning/test/launch/hybrid_planning_common.py b/moveit_ros/hybrid_planning/test/launch/hybrid_planning_common.py
@@ -198,7 +198,10 @@ def generate_common_hybrid_launch_description():
     ros2_control_node = Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )
 

diff --git a/moveit_ros/moveit_servo/launch/demo_joint_jog.launch.py b/moveit_ros/moveit_servo/launch/demo_joint_jog.launch.py
@@ -48,7 +48,10 @@ def generate_launch_description():
     ros2_control_node = launch_ros.actions.Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[moveit_config.robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )
 

diff --git a/moveit_ros/moveit_servo/launch/demo_pose.launch.py b/moveit_ros/moveit_servo/launch/demo_pose.launch.py
@@ -48,7 +48,10 @@ def generate_launch_description():
     ros2_control_node = launch_ros.actions.Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[moveit_config.robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )
 

diff --git a/moveit_ros/moveit_servo/launch/demo_ros_api.launch.py b/moveit_ros/moveit_servo/launch/demo_ros_api.launch.py
@@ -56,7 +56,10 @@ def generate_launch_description():
     ros2_control_node = launch_ros.actions.Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[moveit_config.robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )
 

diff --git a/moveit_ros/moveit_servo/launch/demo_twist.launch.py b/moveit_ros/moveit_servo/launch/demo_twist.launch.py
@@ -48,7 +48,10 @@ def generate_launch_description():
     ros2_control_node = launch_ros.actions.Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[moveit_config.robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )
 

diff --git a/moveit_ros/moveit_servo/tests/launch/servo_cpp_integration.test.py b/moveit_ros/moveit_servo/tests/launch/servo_cpp_integration.test.py
@@ -34,7 +34,10 @@ def generate_test_description():
     ros2_control_node = launch_ros.actions.Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[moveit_config.robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )
 

diff --git a/moveit_ros/moveit_servo/tests/launch/servo_ros_integration.test.py b/moveit_ros/moveit_servo/tests/launch/servo_ros_integration.test.py
@@ -41,7 +41,10 @@ def generate_test_description():
     ros2_control_node = launch_ros.actions.Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[moveit_config.robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )
 

diff --git a/moveit_ros/moveit_servo/tests/launch/servo_utils.test.py b/moveit_ros/moveit_servo/tests/launch/servo_utils.test.py
@@ -34,7 +34,10 @@ def generate_test_description():
     ros2_control_node = launch_ros.actions.Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[moveit_config.robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )
 

diff --git a/moveit_ros/planning_interface/test/launch/move_group_launch_test_common.py b/moveit_ros/planning_interface/test/launch/move_group_launch_test_common.py
@@ -60,7 +60,10 @@ def generate_move_group_test_description(*args, gtest_name: SomeSubstitutionsTyp
     ros2_control_node = Node(
         package="controller_manager",
         executable="ros2_control_node",
-        parameters=[moveit_config.robot_description, ros2_controllers_path],
+        parameters=[ros2_controllers_path],
+        remappings=[
+            ("/controller_manager/robot_description", "/robot_description"),
+        ],
         output="screen",
     )