Use target_include_directories

moveit_core/CMakeLists.txt

@@ -55,34 +55,6 @@ include(ConfigExtras.cmake)
 # Set target file path for version.h
 set(VERSION_FILE_PATH ${CMAKE_BINARY_DIR}/include)
 
-set(THIS_PACKAGE_INCLUDE_DIRS
-    exceptions/include
-    collision_detection/include
-    collision_detection_fcl/include
-    collision_detection_bullet/include
-    constraint_samplers/include
-    controller_manager/include
-    distance_field/include
-    collision_distance_field/include
-    dynamics_solver/include
-    kinematics_base/include
-    kinematics_metrics/include
-    robot_model/include
-    transforms/include
-    robot_state/include
-    robot_trajectory/include
-    kinematic_constraints/include
-    macros/include
-    online_signal_smoothing/include
-    planning_interface/include
-    planning_request_adapter/include
-    planning_scene/include
-    # TODO: Port python bindings
-    # python/tools/include
-    trajectory_processing/include
-    utils/include
-)
-
 set(THIS_PACKAGE_LIBRARIES
     moveit_butterworth_filter
     moveit_collision_distance_field
@@ -96,6 +68,7 @@ set(THIS_PACKAGE_LIBRARIES
     moveit_kinematics_base
     moveit_kinematic_constraints
     moveit_kinematics_metrics
+    moveit_macros
     moveit_planning_interface
     moveit_planning_scene
     moveit_planning_request_adapter
@@ -135,13 +108,6 @@ set(THIS_PACKAGE_INCLUDE_DEPENDS
   ruckig
 )
 
-include_directories(SYSTEM ${EIGEN3_INCLUDE_DIRS}
-  ${LIBFCL_INCLUDE_DIRS}
-)
-
-include_directories(${THIS_PACKAGE_INCLUDE_DIRS}
-                    ${VERSION_FILE_PATH})
-
 # Generate and install version.h
 string(REGEX REPLACE "^([0-9]+)\\..*" "\\1" MOVEIT_VERSION_MAJOR "${${PROJECT_NAME}_VERSION}")
 string(REGEX REPLACE "^[0-9]+\\.([0-9]+).*" "\\1" MOVEIT_VERSION_MINOR "${${PROJECT_NAME}_VERSION}")

moveit_core/collision_detection/CMakeLists.txt

@@ -9,6 +9,10 @@ add_library(moveit_collision_detection SHARED
   src/collision_env.cpp
   src/collision_plugin_cache.cpp
 )
+target_include_directories(moveit_collision_detection PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 include(GenerateExportHeader)
 generate_export_header(moveit_collision_detection)
 
@@ -54,5 +58,5 @@ if(BUILD_TESTING)
   target_link_libraries(test_all_valid moveit_collision_detection moveit_robot_model)
 endif()
 
-install(DIRECTORY include/ DESTINATION include)
-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_collision_detection_export.h DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_collision_detection_export.h DESTINATION include/moveit_core)

moveit_core/collision_detection_bullet/CMakeLists.txt

@@ -7,6 +7,10 @@ add_library(moveit_collision_detection_bullet SHARED
   src/bullet_integration/contact_checker_common.cpp
   src/bullet_integration/ros_bullet_utils.cpp
 )
+target_include_directories(moveit_collision_detection_bullet PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 include(GenerateExportHeader)
 generate_export_header(moveit_collision_detection_bullet)
 target_include_directories(moveit_collision_detection_bullet PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>)
@@ -45,8 +49,8 @@ target_link_libraries(collision_detector_bullet_plugin
   moveit_planning_scene
 )
 
-install(DIRECTORY include/ DESTINATION include)
-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_collision_detection_bullet_export.h DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_collision_detection_bullet_export.h DESTINATION include/moveit_core)
 install(TARGETS moveit_collision_detection_bullet collision_detector_bullet_plugin EXPORT export_moveit_collision_detection_bullet
   LIBRARY DESTINATION lib
   ARCHIVE DESTINATION lib

moveit_core/collision_detection_fcl/CMakeLists.txt

@@ -2,6 +2,10 @@ add_library(moveit_collision_detection_fcl SHARED
   src/collision_common.cpp
   src/collision_env_fcl.cpp
 )
+target_include_directories(moveit_collision_detection_fcl PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 include(GenerateExportHeader)
 generate_export_header(moveit_collision_detection_fcl)
 target_include_directories(moveit_collision_detection_fcl PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>)
@@ -33,8 +37,8 @@ target_link_libraries(collision_detector_fcl_plugin
   moveit_planning_scene
 )
 
-install(DIRECTORY include/ DESTINATION include)
-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_collision_detection_fcl_export.h DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_collision_detection_fcl_export.h DESTINATION include/moveit_core)
 
 if(BUILD_TESTING)
   if(WIN32)

moveit_core/collision_distance_field/CMakeLists.txt

@@ -4,6 +4,10 @@ add_library(moveit_collision_distance_field SHARED
   src/collision_env_distance_field.cpp
   src/collision_env_hybrid.cpp
 )
+target_include_directories(moveit_collision_distance_field PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 include(GenerateExportHeader)
 generate_export_header(moveit_collision_distance_field)
 target_include_directories(moveit_collision_distance_field PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>)
@@ -24,8 +28,8 @@ target_link_libraries(moveit_collision_distance_field
   moveit_robot_state
 )
 
-install(DIRECTORY include/ DESTINATION include)
-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_collision_distance_field_export.h DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_collision_distance_field_export.h DESTINATION include/moveit_core)
 
 if(BUILD_TESTING)
   find_package(ament_cmake_gtest REQUIRED)

moveit_core/constraint_samplers/CMakeLists.txt

@@ -5,6 +5,10 @@ add_library(moveit_constraint_samplers SHARED
   src/default_constraint_samplers.cpp
   src/union_constraint_sampler.cpp
 )
+target_include_directories(moveit_constraint_samplers PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 set_target_properties(moveit_constraint_samplers PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
 ament_target_dependencies(moveit_constraint_samplers
   urdf
@@ -20,7 +24,7 @@ target_link_libraries(moveit_constraint_samplers
   moveit_planning_scene
 )
 
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)
 
 if(BUILD_TESTING)
   find_package(ament_cmake_gmock REQUIRED)

moveit_core/controller_manager/CMakeLists.txt

@@ -1 +1 @@
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)

moveit_core/distance_field/CMakeLists.txt

@@ -3,7 +3,11 @@ add_library(moveit_distance_field SHARED
   src/find_internal_points.cpp
   src/propagation_distance_field.cpp
 )
-
+target_include_directories(moveit_distance_field PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
+target_link_libraries(moveit_distance_field moveit_macros)
 set_target_properties(moveit_distance_field PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
 ament_target_dependencies(moveit_distance_field
   Boost
@@ -15,7 +19,7 @@ ament_target_dependencies(moveit_distance_field
   OCTOMAP
 )
 
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)
 
 if(BUILD_TESTING)
   find_package(ament_cmake_gtest REQUIRED)

moveit_core/dynamics_solver/CMakeLists.txt

@@ -1,4 +1,8 @@
 add_library(moveit_dynamics_solver SHARED src/dynamics_solver.cpp)
+target_include_directories(moveit_dynamics_solver PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 set_target_properties(moveit_dynamics_solver PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
 
 ament_target_dependencies(moveit_dynamics_solver
@@ -12,4 +16,4 @@ target_link_libraries(moveit_dynamics_solver
   moveit_robot_state
 )
 
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)

moveit_core/exceptions/CMakeLists.txt

@@ -1,4 +1,8 @@
 add_library(moveit_exceptions SHARED src/exceptions.cpp)
+target_include_directories(moveit_exceptions PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 set_target_properties(moveit_exceptions PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
 ament_target_dependencies(moveit_exceptions
   Boost
@@ -7,4 +11,4 @@ ament_target_dependencies(moveit_exceptions
   urdfdom_headers
 )
 
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)

moveit_core/kinematic_constraints/CMakeLists.txt

@@ -8,7 +8,10 @@ add_library(moveit_kinematic_constraints SHARED
   src/kinematic_constraint.cpp
   src/utils.cpp
 )
-
+target_include_directories(moveit_kinematic_constraints PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 set_target_properties(moveit_kinematic_constraints PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
 
 ament_target_dependencies(moveit_kinematic_constraints
@@ -29,7 +32,7 @@ target_link_libraries(moveit_kinematic_constraints
   moveit_utils
 )
 
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)
 
 if(BUILD_TESTING)
   find_package(ament_cmake_gtest REQUIRED)

moveit_core/kinematics_base/CMakeLists.txt

@@ -1,6 +1,9 @@
-cmake_minimum_required(VERSION 3.22)
-
 add_library(moveit_kinematics_base SHARED src/kinematics_base.cpp)
+target_include_directories(moveit_kinematics_base PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
+target_link_libraries(moveit_kinematics_base moveit_macros moveit_robot_model)
 include(GenerateExportHeader)
 generate_export_header(moveit_kinematics_base)
 target_include_directories(moveit_kinematics_base PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>)  # for this library
@@ -16,5 +19,5 @@ ament_target_dependencies(
   geometry_msgs
 )
 
-install(DIRECTORY include/ DESTINATION include)
-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_kinematics_base_export.h DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_kinematics_base_export.h DESTINATION include/moveit_core)

moveit_core/kinematics_metrics/CMakeLists.txt

@@ -1,4 +1,8 @@
 add_library(moveit_kinematics_metrics SHARED src/kinematics_metrics.cpp)
+target_include_directories(moveit_kinematics_metrics PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 set_target_properties(moveit_kinematics_metrics PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
 
 ament_target_dependencies(moveit_kinematics_metrics
@@ -11,4 +15,4 @@ target_link_libraries(moveit_kinematics_metrics
   moveit_robot_state
 )
 
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)

moveit_core/macros/CMakeLists.txt

@@ -1 +1,7 @@
-install(DIRECTORY include/ DESTINATION include)
+add_library(moveit_macros INTERFACE)
+target_include_directories(moveit_macros INTERFACE
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
+
+install(DIRECTORY include/ DESTINATION include/moveit_core)

moveit_core/online_signal_smoothing/CMakeLists.txt

@@ -1,45 +1,46 @@
 # Base class
-set(SMOOTHING_BASE_LIB moveit_smoothing_base)
-add_library(${SMOOTHING_BASE_LIB} SHARED
+add_library(moveit_smoothing_base SHARED
   src/smoothing_base_class.cpp
 )
-include(GenerateExportHeader)
-generate_export_header(${SMOOTHING_BASE_LIB})
-target_include_directories(${SMOOTHING_BASE_LIB} PUBLIC
+target_include_directories(moveit_smoothing_base PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
   $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>
+  $<INSTALL_INTERFACE:include/moveit_core>
 )
-set_target_properties(${SMOOTHING_BASE_LIB} PROPERTIES VERSION
+target_link_libraries(moveit_smoothing_base moveit_macros)
+include(GenerateExportHeader)
+generate_export_header(moveit_smoothing_base)
+set_target_properties(moveit_smoothing_base PROPERTIES VERSION
   "${${PROJECT_NAME}_VERSION}"
 )
-ament_target_dependencies(${SMOOTHING_BASE_LIB}
+ament_target_dependencies(moveit_smoothing_base
   rclcpp
 )
 
 # Plugin implementations
-set(BUTTERWORTH_FILTER_LIB moveit_butterworth_filter)
-add_library(${BUTTERWORTH_FILTER_LIB} SHARED
+add_library(moveit_butterworth_filter SHARED
   src/butterworth_filter.cpp
 )
-generate_export_header(${BUTTERWORTH_FILTER_LIB})
-target_include_directories(${BUTTERWORTH_FILTER_LIB} PUBLIC
+generate_export_header(moveit_butterworth_filter)
+target_include_directories(moveit_butterworth_filter PUBLIC
   $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>
 )
-set_target_properties(${BUTTERWORTH_FILTER_LIB} PROPERTIES VERSION
+set_target_properties(moveit_butterworth_filter PROPERTIES VERSION
   "${${PROJECT_NAME}_VERSION}"
 )
-target_link_libraries(${BUTTERWORTH_FILTER_LIB}
-  ${SMOOTHING_BASE_LIB}
+target_link_libraries(moveit_butterworth_filter
+  moveit_smoothing_base
   moveit_robot_model
 )
-ament_target_dependencies(${BUTTERWORTH_FILTER_LIB}
+ament_target_dependencies(moveit_butterworth_filter
   srdfdom  # include dependency from moveit_robot_model
 )
 
 # Installation
 
-install(DIRECTORY include/ DESTINATION include)
-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${SMOOTHING_BASE_LIB}_export.h DESTINATION include)
-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${BUTTERWORTH_FILTER_LIB}_export.h DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_smoothing_base_export.h DESTINATION include/moveit_core)
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_butterworth_filter_export.h DESTINATION include/moveit_core)
 
 # Testing
 
@@ -49,5 +50,5 @@ if(BUILD_TESTING)
 
   # Lowpass filter unit test
   ament_add_gtest(test_butterworth_filter test/test_butterworth_filter.cpp)
-  target_link_libraries(test_butterworth_filter ${BUTTERWORTH_FILTER_LIB})
+  target_link_libraries(test_butterworth_filter moveit_butterworth_filter)
 endif()

moveit_core/planning_interface/CMakeLists.txt

@@ -2,6 +2,10 @@ add_library(moveit_planning_interface SHARED
   src/planning_interface.cpp
   src/planning_response.cpp
 )
+target_include_directories(moveit_planning_interface PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 set_target_properties(moveit_planning_interface PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
 ament_target_dependencies(moveit_planning_interface
   moveit_msgs
@@ -12,6 +16,7 @@ ament_target_dependencies(moveit_planning_interface
 target_link_libraries(moveit_planning_interface
   moveit_robot_trajectory
   moveit_robot_state
+  moveit_utils
 )
 
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)

moveit_core/planning_request_adapter/CMakeLists.txt

@@ -1,4 +1,8 @@
 add_library(moveit_planning_request_adapter SHARED src/planning_request_adapter.cpp)
+target_include_directories(moveit_planning_request_adapter PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include/moveit_core>
+)
 set_target_properties(moveit_planning_request_adapter PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
 ament_target_dependencies(moveit_planning_request_adapter
   rclcpp
@@ -10,6 +14,7 @@ ament_target_dependencies(moveit_planning_request_adapter
 )
 target_link_libraries(moveit_planning_request_adapter
   moveit_planning_scene
+  moveit_planning_interface
 )
 
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION include/moveit_core)