Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSA] Port moveit_setup_simulation #1262

Open
DLu opened this issue May 19, 2022 · 4 comments
Open

[MSA] Port moveit_setup_simulation #1262

DLu opened this issue May 19, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@DLu
Copy link
Contributor

DLu commented May 19, 2022

The moveit_setup_simulation package is currently ignored, and does not compile.

In ROS 1, this step would attempt to modify your original URDF file to add the needed attributes for simulation and write it to config/gazebo_[ROBOT_NAME].urdf if the original location could not be modified. It would generate

  • config/gazebo_controllers.yaml - Configuration of Gazebo controllers
  • launch/gazebo.launch - Gazebo launch file which also launches ros_controllers and sends robot urdf to param server, then using gazebo_ros pkg the robot is spawned to Gazebo
  • launch/demo_gazebo.launch - Run a demo of MoveIt with Gazebo and Rviz
  • config/gazebo_[ROBOT_NAME].urdf (sometimes)

The edits made to the urdf include:

  • Adding <inertial> tags to <collision> elements of <link> elements.
  • Adding <transmission> tags for each <joint> element.
  • Adding the <gazebo> tag (globally) and specifying <plugin> elements inside.

Which of these steps need to be done for ROS 2 Ignition Gazebo? Is it within the scope of this repo? Could it just be made into its own Setup Assistant using this framework?

@DLu DLu added the enhancement New feature or request label May 19, 2022
@abake48 abake48 self-assigned this Jun 2, 2022
@DLu
Copy link
Contributor Author

DLu commented Jun 9, 2022

@abake48 I made some boilerplate for generating the simulation xacro here: https://github.com/DLu/moveit2/tree/feature/sim_xacro/moveit_setup_assistant/moveit_setup_simulation

@abake48
Copy link
Contributor

abake48 commented Jun 9, 2022

Thank you! I'll be spending all day tomorrow working on this so this can get released!

@DLu
Copy link
Contributor Author

DLu commented Jun 20, 2022

@ahcorde @chapulina Can you help us define what is needed in a URDF for simulation? Assuming it already has ros2_control tags, it looks like we need to replace the gazebo_ros_control plugin with libign_ros2_control-system.so. I'm guessing we don't need transmissions anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants