Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick() and place() functions in moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp commented #1951

Closed
atuldivekar opened this issue Feb 16, 2023 · 5 comments · Fixed by #2239
Assignees
Labels
question Further information is requested stale Inactive issues and PRs are marked as stale and may be closed automatically.

Comments

@atuldivekar
Copy link

Description

pick() and place() functions in moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp
are commented which causes code to fail.

There is no documentation to indicate this is deprecated and tutorials such as
https://github.com/ros-planning/moveit2_tutorials/blob/main/doc/examples/pick_place/src/pick_place_tutorial.cpp
still use these functions

  • ROS Distro: Humble
  • OS Version: Ubuntu 22.04
  • Binary build for ROS2 Humble , source build for MoveIt2 Humble branch
    Cyclone DDS

Steps to reproduce

I tried to create a simple pick and place demo.

The relevant lines are :

#include <moveit/planning_scene_interface/planning_scene_interface.h>
#include <moveit/move_group_interface/move_group_interface.h>

...

move_group_interface_ptr_ = new MoveGroupInterface(node_,"panda_arm");
move_group_interface_ptr_->pick("object", grasps);

Compiler error:

error: ‘class moveit::planning_interface::MoveGroupInterface’ has no member named ‘pick’

The code for pick() etc. appears to be commented in
moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp

If this is deprecated, this should be documented and the tutorials updated.
If deprecated, what is the alternative to use? MoveIt Task Constructor?

@atuldivekar atuldivekar added the bug Something isn't working label Feb 16, 2023
@DaniGarciaLopez
Copy link
Contributor

I am also interested to know why these functions are commented out. If they are deprecated in Humble I would like to find a simple alternative to pick up objects from the planning scene without the use of Moveit Task Constructor. Thanks!

@henningkayser henningkayser added question Further information is requested and removed bug Something isn't working labels Mar 10, 2023
@henningkayser
Copy link
Member

@atuldivekar the tutorial states that it is deprecated and, the pick place capability has been removed a while ago (#1177). However, you are right that commented code in the main repo is not great. Would you mind filing a PR to remove it along with the tutorial?

And yes, MoveIt Task Constructor is really the best solution for pick and place tasks.https://moveit.picknik.ai/humble/doc/tutorials/pick_and_place_with_moveit_task_constructor/pick_and_place_with_moveit_task_constructor.html

@henningkayser henningkayser self-assigned this Mar 10, 2023
@github-actions
Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Apr 25, 2023
@antonio1matos
Copy link

@DaniGarciaLopez did you found a way to pick up objects from the planning scene avoiding the use of Moveit Task Constructor?

@DaniGarciaLopez
Copy link
Contributor

@antonio1matos We decided to use MoveIt Task Constructor. It has many introspection tools and it's worth a try for simple pick/place tasks as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested stale Inactive issues and PRs are marked as stale and may be closed automatically.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants