Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on 3rd party ament packages via target_link_libraries where possible #2583

Open
ChrisThrasher opened this issue Dec 7, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed infrastructure persistent Allows issues to remain open without automatic stalling and closing.

Comments

@ChrisThrasher
Copy link
Contributor

Many modern ROS packages export a single CMake target that encodes everything required to use it. For those packages we are better off using target_link_libraries to link to that target. It's the simpler and canonical solution to linking to 3rd party libraries.

This has the benefit of ensuring that if a target doesn't exist we get a hard failure. Any namespaces CMake target (any target with :: in its name) must exist or else configuration fails. This prevents subtle issues like what caused #2578.

@ChrisThrasher ChrisThrasher added the enhancement New feature or request label Dec 7, 2023
Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Jan 22, 2024
@sjahr sjahr added persistent Allows issues to remain open without automatic stalling and closing. help wanted Extra attention is needed and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed infrastructure persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

No branches or pull requests

3 participants