Change default_request_adapter_parameters.default_workspace_bounds value
#2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pac48
force-pushed
the
pr-change-default-workspace-bounds
branch
from
30befa0
to
1cccf5f
Compare
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
pac48
force-pushed
the
pr-change-default-workspace-bounds
branch
from
1cccf5f
to
baa3347
Compare
sjahr
approved these changes
Apr 24, 2024
henningkayser
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
default_workspace_boundsis arbitrarily set to 10. This value can lead to confusion, especially when using a mobile robot. I think setting it to a large number may be a more appropriate default, e.g. no workspace bound exists unless explicitly specified.