Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSA] Three small edits #1203

Merged
merged 3 commits into from
May 2, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ repos:
- id: trailing-whitespace

- repo: https://github.com/psf/black
rev: 20.8b1
rev: 22.3.0
hooks:
- id: black

Expand Down
2 changes: 1 addition & 1 deletion moveit_setup_assistant/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,4 @@ The format for the templates is custom to MSA. Let's assume you have a `Template

becomes

<name>r2d2_moveit_config</name>
<name>r2d2_moveit_config</name>
6 changes: 0 additions & 6 deletions moveit_setup_assistant/moveit_setup_assistant/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,6 @@ int main(int argc, char** argv)
auto client = std::make_unique<rviz_common::ros_integration::RosClientAbstraction>();
auto node = client->init(argc, argv, "moveit_setup_assistant", false);

/* TODO:
* Migration Notes:
* ROS 1 MSA had an explicit SIGINT handler (ros::init_options::NoSigintHandler) not replicated here
* ROS 1 MSA also started an ASyncSpinner
*/

// Create Qt Application
QApplication qt_app(argc, argv);
// numeric values should always be POSIX
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
#include <QList>
#include <QLabel>
#include <QListWidget>
#include <QListWidget>
#include <QListWidgetItem>
#include <QProgressBar>
#include <QPushButton>
Expand Down