Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'return false' in plan, move and execute such that MoveItErrorCode is returned #1266

Merged
merged 1 commit into from
Jul 29, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ class MoveGroupInterface::MoveGroupInterfaceImpl
if (code != rclcpp_action::ResultCode::SUCCEEDED)
{
RCLCPP_ERROR_STREAM(LOGGER, "MoveGroupInterface::plan() failed or timeout reached");
return false;
return res->error_code;
AndyZe marked this conversation as resolved.
Show resolved Hide resolved
}

plan.trajectory_ = res->planned_trajectory;
Expand Down Expand Up @@ -873,7 +873,6 @@ class MoveGroupInterface::MoveGroupInterfaceImpl
if (code != rclcpp_action::ResultCode::SUCCEEDED)
{
RCLCPP_ERROR_STREAM(LOGGER, "MoveGroupInterface::move() failed or timeout reached");
return false;
}
return res->error_code;
}
Expand Down Expand Up @@ -941,7 +940,6 @@ class MoveGroupInterface::MoveGroupInterfaceImpl
if (code != rclcpp_action::ResultCode::SUCCEEDED)
{
RCLCPP_ERROR_STREAM(LOGGER, "MoveGroupInterface::execute() failed or timeout reached");
return false;
}
return res->error_code;
}
Expand Down