Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix moveit_core building #1553

Merged
merged 5 commits into from
Sep 7, 2022
Merged

Fix moveit_core building #1553

merged 5 commits into from
Sep 7, 2022

Commits on Sep 6, 2022

  1. Add missing srdfdom dependency

    @rhaschke
    rhaschke committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a36607f View commit details
    Browse the repository at this point in the history

  2. moveit_core/collision_detection: fix include order 

    moveit_planning_scene's include directories have to be appended
to the include directories found by ament_target_dependencies().
    @rhaschke
    rhaschke committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    072482c View commit details
    Browse the repository at this point in the history

  3. Use standard exported targets: export_${PROJECT_NAME} -> ${PROJECT_NA… 

    …ME}Targets
    @rhaschke
    rhaschke committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    1e6af35 View commit details
    Browse the repository at this point in the history

  4. Cleanup cmake files 

    - Replace ament_export_libraries() -> ament_export_targets(HAS_LIBRARY_TARGET)
- Replace ament_export_include_directories() -> INCLUDES DESTINATION include

See https://docs.ros.org/en/foxy/How-To-Guides/Ament-CMake-Documentation.html#building-a-library
    @rhaschke
    rhaschke committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7b01290 View commit details
    Browse the repository at this point in the history

  5. Remove callback_executor_.is_spinning()

    @rhaschke
    rhaschke committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    ba62fe3 View commit details
    Browse the repository at this point in the history