Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #1908 and #2035 #2081

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Apr 5, 2023

Description

Replaces #2042

In attempt to make CI green on the humble branch as well, we are backporting #2039 (see #2040). However, #2040 is currently blocked by a backport of #1908 (#2040 (comment)). I also believe that we should backport #2035 so that Docker images behave as expected and don't break CI.

Once this PR is merged into humble, we should re-trigger the CI on #2040 to make sure it's green. If so, we can merge #2040 as well.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify
Copy link

mergify bot commented Apr 5, 2023

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 76.93% and project coverage change: +0.02 🎉

Comparison is base (05f3c6d) 50.93% compared to head (c06ddee) 50.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #2081      +/-   ##
==========================================
+ Coverage   50.93%   50.95%   +0.02%     
==========================================
  Files         381      382       +1     
  Lines       31884    31878       -6     
==========================================
+ Hits        16238    16240       +2     
+ Misses      15646    15638       -8     
Impacted Files Coverage Δ
.../moveit_servo/include/moveit_servo/pose_tracking.h 100.00% <ø> (ø)
moveit_ros/moveit_servo/src/utilities.cpp 74.47% <74.47%> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp 66.45% <100.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vatanaksoytezer vatanaksoytezer merged commit 66b144a into moveit:humble Apr 5, 2023
@adlarkin adlarkin deleted the backport-1908 branch April 5, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants