Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in bullet function name #2472

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

stephanie-eng
Copy link
Contributor

Change addAttachedOjects to addAttachedObjects.

This function is a protected member of CollisionEnvBullet, so this may lead to breakages if a user is inheriting from CollisionEnvBullet. If we think it's best to deprecate the typo version, I'm also not against making the change in that way.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15d9d61) 50.81% compared to head (5c7ef66) 50.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2472      +/-   ##
==========================================
- Coverage   50.81%   50.34%   -0.47%     
==========================================
  Files         391      390       -1     
  Lines       32125    31954     -171     
==========================================
- Hits        16322    16084     -238     
- Misses      15803    15870      +67     
Files Coverage Δ
...sion_detection_bullet/src/collision_env_bullet.cpp 84.93% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr merged commit faa4795 into moveit:main Oct 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants