Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(moveit_py) Extend Trajectory Execution Manager #2569

Conversation

JensVanhooydonck
Copy link
Contributor

Added part of the functions from #2442

Description

Added execute, execute_and_wait, wait_for_execution and get_last_execution_status.
I also added py::call_guardpy::gil_scoped_release() for the (possible) long running calls to free up the ptyhon thread.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bddab3f) 50.87% compared to head (5632668) 50.46%.
Report is 1 commits behind head on main.

❗ Current head 5632668 differs from pull request most recent head 25ba427. Consider uploading reports for the commit 25ba427 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2569      +/-   ##
==========================================
- Coverage   50.87%   50.46%   -0.41%     
==========================================
  Files         388      387       -1     
  Lines       32253    32078     -175     
==========================================
- Hits        16407    16186     -221     
- Misses      15846    15892      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MatthijsBurgh MatthijsBurgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 3 small improvements left from my side

JensVanhooydonck and others added 3 commits December 4, 2023 13:12
…rajectory_execution_manager.cpp

Co-authored-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>
…rajectory_execution_manager.cpp

Co-authored-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>
@MatthijsBurgh
Copy link
Contributor

@JensVanhooydonck You have some whitespace issues in trajectory_execution_manager.cpp. See the formatting job.

@sjahr sjahr enabled auto-merge (squash) December 4, 2023 23:57
@sjahr sjahr merged commit 7ab329d into moveit:main Dec 5, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants