-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(moveit_py) Extend Trajectory Execution Manager #2569
(moveit_py) Extend Trajectory Execution Manager #2569
Conversation
Added part of the functions from moveit#2442
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
==========================================
- Coverage 50.87% 50.46% -0.41%
==========================================
Files 388 387 -1
Lines 32253 32078 -175
==========================================
- Hits 16407 16186 -221
- Misses 15846 15892 +46 ☔ View full report in Codecov by Sentry. |
moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp
Outdated
Show resolved
Hide resolved
moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp
Outdated
Show resolved
Hide resolved
moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp
Show resolved
Hide resolved
moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp
Outdated
Show resolved
Hide resolved
moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 3 small improvements left from my side
moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp
Outdated
Show resolved
Hide resolved
moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp
Outdated
Show resolved
Hide resolved
…rajectory_execution_manager.cpp Co-authored-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>
…rajectory_execution_manager.cpp Co-authored-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>
@JensVanhooydonck You have some whitespace issues in |
Added part of the functions from #2442
Description
Added execute, execute_and_wait, wait_for_execution and get_last_execution_status.
I also added py::call_guardpy::gil_scoped_release() for the (possible) long running calls to free up the ptyhon thread.
Checklist