Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use UNDERLAY feature of industrial_ci" #82

Merged
merged 1 commit into from
May 3, 2021

Conversation

JStech
Copy link
Contributor

@JStech JStech commented May 1, 2021

Reverts #76. Locally, when I run rosrun industrial_ci rerun_ci with the UNDERLAY argument, it fails to find catkin when building the upstream workspace. Switching back to the old way fixes it.

@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #82 (bb408b2) into master (3ffd736) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   72.75%   72.75%           
=======================================
  Files          10       10           
  Lines         554      554           
=======================================
  Hits          403      403           
  Misses        151      151           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffd736...bb408b2. Read the comment docs.

@JStech JStech requested a review from tylerjw May 1, 2021 04:38
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should submit this as an issue to industrial_ci and link the CI runs and the config. This should work.

@JStech JStech merged commit 034f951 into master May 3, 2021
@tylerjw tylerjw deleted the revert-76-ws_moveit-underlay branch May 3, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants