Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure panda joint limits have the proper type #63

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Apr 18, 2021

No description provided.

@AndyZe AndyZe changed the base branch from master to ros2 April 18, 2021 18:16
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that our code should be robust against being fed with integers. Other users might face the same issue.
@AndyZe, where exactly did you face a problem?

@AndyZe
Copy link
Member Author

AndyZe commented Apr 18, 2021

I'm not sure joint_limits.yaml types were causing an issue anywhere, but maybe it will fix the issue discussed here. (moveit2 423)

In moveit2_servo, there were some warnings like this coming from a different yaml file:

InvalidParameterTypeException(moveit_servo.collision_check_rate): parameter 'moveit_servo.collision_check_rate' has invalid type: expected [double] got [integer]

I made a PR to fix the Servo types here. I guess it likely would not have caused any runtime errors but good to fix anyway.

The code where these parameters get parsed (in moveit2_servo) is here. I'll try to test if the error handling there is working correctly.

@AndyZe
Copy link
Member Author

AndyZe commented Apr 18, 2021

Going to merge now so we can see if the flaky Servo tests are fixed.

@AndyZe AndyZe merged commit 80cd613 into moveit:ros2 Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants