fixed links to dcoleman github causing build to fail #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial build failed with this error: Both links had the same hyperlink text, which it turns out that sphinx does't like. Googling got me to this github issue and subsequently this SO post on a solution. Using anonymous links seemed different than I've seen on ROS in general, so I didn't feel bold enough to change them to that. I just took some artistic license with what to use for the linked text; hopefully that's alright. After these worked themselves out, I caught the bullet list that borked #96 and was introduced in #92 so I added that here as well. All is passing now! |
|
Wow. Thanks a lot for tracking this down! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to fix #96 and swear that Travis Cl complained due to bad links in
perception_configuration.rst, so I looked around and found that #101 added links to non-existent github pages.I think the below is what was intended, but now my build on #96 is failing for a different reason! Nevertheless, these are still wrong on the live docs, so I think this is still a good change to make.