Replace tf_conversions with tf2::convert #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing due to clang-tidy |
rhaschke
reviewed
Jun 7, 2020
src/imarker_end_effector.cpp
Outdated
| #include <eigen_conversions/eigen_msg.h> | ||
| #include <tf_conversions/tf_eigen.h> | ||
| #include <tf2_eigen/tf2_eigen.h> | ||
| #include <tf2/convert.h> |
There was a problem hiding this comment.
This line is redundant
Suggested change
| #include <tf2/convert.h> |
rhaschke
approved these changes
Jun 7, 2020
v4hn
approved these changes
Jun 8, 2020
|
Closing and reopening to trigger Travis. |
|
Remaining clang-tidy issue is fixed in #68. |
tylerjw
approved these changes
Jun 16, 2020
|
merge? |
v4hn
pushed a commit
to v4hn/moveit_visual_tools
that referenced
this pull request
Aug 3, 2020
rhaschke
pushed a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf_conversions was still in use in one compilation unit