Use true JID of message sender when we know it #1178
Conversation
Instead of always trying to infer from MUC presences later.
Set true counterpart JID by XEP-0033 ofrom, but only when it is quite safe, that is when the domain of the ofrom matches the domain of the from, and that domain advertises support for XEP-0033 itself. When we do this, also allow for a fallback body.
|
In which context does Movim do 0033? (TIL). I would suggest not to use the realjid when we're not Also, not much we can do as long as there's no way to do validation, but this is probably going to come bite us at some point: |
|
I still don't know exactly why this PR is for, I'll try to figure it out 🤔 |
|
In which context does Movim do 0033? (TIL).
In this context that I just wrote in this PR.
I would suggest not to use the realjid when we're not `whois = anyone` and we're a moderator. I don't know if it's comparable but 392 does this, bases the color on realjids, and it's actually annoying seeing colors change for the same person in different rooms just because we have different permissions.
This PR does not use realjid for colour in MUC. It does use it to show both
your name for a person as well as their MUC resource, and get easy access to
their JID right on the message when it is known.
…--
Stephen Paul Weber, @singpolyma
See <http://singpolyma.net> for how I prefer to be contacted
edition right joseph
|
|
I still don't know exactly why this PR is for, I'll try to figure it out
:thinking:
For me the biggest purpose is the 0033 implementation I added, but being
able to see my name for a MUC user to know who they are is also very
helpful, etc.
…--
Stephen Paul Weber, @singpolyma
See <http://singpolyma.net> for how I prefer to be contacted
edition right joseph
|
|
Just following up here with respect to the "more info" label -- happy to provide more info if needed :) |
|
Just adding my comments here as well, I have chats where I'd need to see my local name for a contact so I can tell who is who in a group of say coworkers who all have weird usernames |
|
+1 merge this |
|
Any news on this PR? |
Save true counterpart JID of MUC sender when we know it.
Set true counterpart JID by XEP-0033 ofrom, but only when it is quite safe, that is when the domain of the ofrom matches the domain of the from, and that domain advertises support for XEP-0033 itself. (Allowing for fallback body in conjunction with this.)
Show nickname and icon based on true counterpart JID when we know it.