Avoid requests #17
Merged
Avoid requests #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @andybar2 maybe you can take a look at this one. Thank you :) |
| @@ -25,6 +25,7 @@ var lnCms = angular.module('lnCms', [ | |||
| var state = { | |||
| name: route.state, | |||
| url: route.url, | |||
| request: 'request' in route ? route.request : true, | |||
There was a problem hiding this comment.
All the custom data that we attach to the states, should be inside the "data" object. That's the way ui-router recommends in order to avoid conflicts with the reserved options.
|
Thanks for the comments @andybar2 I just update the code based on your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we add the option to avoid the native request to an endpoint where is not required such as the case of the 404 page.
Also some improvements on the code to avoid functions where was not need