Added support for switching OPI buffer to emulator #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,6 +117,15 @@ public: | |||
| ozVSGet(vm, value, valueBufSize, valueStr); | |||
|
|
|||
| auto& stream = boolToStdErr ? std::cerr : std::cout; | |||
|
|
|||
There was a problem hiding this comment.
You have spaces at EOL here. (They show up in the GitHub diff if you select the text.) Spaces at EOL are a source of merge conflicts and weird diffs in the future, so they should be avoided.
I suggest you configure your editor to automatically remove spaces at EOL (and add an EOL at EOF) when saving the file.
|
@sjrd I fixed both issues in my working dir. Do you prefer for me to amend my commit and force push the branch or to add a second commit to the branch? |
|
I prefer that you amend and force push. |
Fixes mozart#107 This uses a new property (errors.prefix) rather than relying on oz.standalone and magic values in the emulator.
|
LGTM. Thanks :) |
sjrd
added a commit
that referenced
this pull request
Feb 9, 2014
Added support for switching OPI buffer to emulator
eregon
pushed a commit
to eregon/mozart2
that referenced
this pull request
Oct 12, 2016
Added support for switching OPI buffer to emulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
This uses a new property (errors.prefix) rather than relying on oz.standalone and magic values in the emulator.